Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pagination arrows should reverse in RTL mode #1250

Closed
mah0o7co opened this issue Jan 2, 2024 · 2 comments
Closed

fix: Pagination arrows should reverse in RTL mode #1250

mah0o7co opened this issue Jan 2, 2024 · 2 comments

Comments

@mah0o7co
Copy link

mah0o7co commented Jan 2, 2024

🐛 Bug Report

Pagination arrows should reverse in RTL mode.

💻 Repro or Code Sample

Go to the data grid "Typical usage" then turn on RTL mode.

🤔 Expected Behavior

Next page should be a left arrow.
Total page should be on the left as well.

😯 Current Behavior

next page is a right arrow.

💁 Possible Solution

🔦 Context

🌍 Your Environment

Doc

@vnbaaij
Copy link
Collaborator

vnbaaij commented Jan 2, 2024

Why? Below images are LTR and RTL versions of a datagrid. If everything is 'mirrored' why would pagination and status be different? Only thing that should probably change is the way the arrow are shown in the paginator (text (order) can already be changed by using the PaginationTextTemplate parameter)

LTR datagrid:
image

RTL datagrid:
image

@mah0o7co
Copy link
Author

mah0o7co commented Jan 3, 2024

Yes, you are right.
The arrows has problem.

@mah0o7co mah0o7co changed the title fix: Pagination should be on right side in RTL mode fix: Pagination arrows should reverse on right side in RTL mode Jan 3, 2024
@mah0o7co mah0o7co changed the title fix: Pagination arrows should reverse on right side in RTL mode fix: Pagination arrows should reverse in RTL mode Jan 3, 2024
@vnbaaij vnbaaij closed this as completed in 83e77a9 Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants