Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1205 FluentButton submit does not work outside the EditForm #v3 #1225

Merged
merged 2 commits into from
Dec 27, 2023

Conversation

vnbaaij
Copy link
Collaborator

@vnbaaij vnbaaij commented Dec 27, 2023

Due to an error on the FAST side (microsoft/fluentui#31506), a FluentButton oouside of a form generates an error when trying to submit. The suggested workaround from the referenced issue is implementend with this PR in a colloacted script. The form as described in microsoft/fast#1205 can be submitted now with the FluentButton being outside of the form.

PR also includes IAsyncDisposable implementaiton for previous Slider PR

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-1225.westeurope.3.azurestaticapps.net

@vnbaaij vnbaaij merged commit 49314fd into dev Dec 27, 2023
3 of 4 checks passed
@vnbaaij vnbaaij deleted the vnbaaij/fix-1205 branch December 27, 2023 16:34
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-1225.westeurope.3.azurestaticapps.net

vnbaaij added a commit that referenced this pull request Dec 28, 2023
…1225)

* Fix #1205 #v3

* Apply this only for submit and reset button, not for ALL buttons.
Make tests pass again
vnbaaij added a commit that referenced this pull request Jan 11, 2024
vnbaaij added a commit that referenced this pull request Jan 11, 2024
vnbaaij added a commit that referenced this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants