Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Templates v4.2.1: type="image/png" -> type="image/x-icon" #1173

Closed
JeepNL opened this issue Dec 20, 2023 · 1 comment
Closed

Templates v4.2.1: type="image/png" -> type="image/x-icon" #1173

JeepNL opened this issue Dec 20, 2023 · 1 comment

Comments

@JeepNL
Copy link

JeepNL commented Dec 20, 2023

Templates v4.2.1
(dotnet new install Microsoft.FluentUI.AspNetCore.Templates::4.2.1)

In App.razor

There's this line:
<link rel="icon" type="image/png" href="favicon.ico" />

And I think it should be:
<link rel="icon" type="image/x-icon" href="favicon.ico">
@vnbaaij
Copy link
Collaborator

vnbaaij commented Dec 20, 2023

Good catch! Will change it for next release.

@vnbaaij vnbaaij closed this as completed Dec 20, 2023
vnbaaij added a commit that referenced this issue Dec 20, 2023
@vnbaaij
Update whatsnew
6b06254 
Fix #1174
Fix #1173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vnbaaij @JeepNL