Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V2 Tabbar] Tab item text responsiveness #735

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[V2 Tabbar] Tab item text responsiveness #735

wants to merge 1 commit into from
+2 −9

Conversation

joyeeta26
Copy link
Contributor

@joyeeta26 joyeeta26 commented Nov 21, 2024 •
edited
Loading

Problem

Tab item text was not adapting correctly with different display sizes

Root cause

In the current implementation, when text was overflowing height, font size was being changed by 0.9, which was leading to inconsistent behaviour
tab bar screen size old

Fix

Removed the font size calculation logic so that text adapts size correctly

Validations

tab bar screen size

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • Automated Tests
  • Documentation and demo app examples
  • VoiceOver and Keyboard Accessibility
  • Internationalization and RTL layouts
  • Size classes and window sizes (notched devices, multitasking, different window sizes, etc)

@joyeeta26 joyeeta26 requested a review from a team as a code owner November 21, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@joyeeta26