Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix positional substitutions in position string #703

Merged
merged 1 commit into from
Oct 7, 2024
Merged

fix positional substitutions in position string #703

merged 1 commit into from
Oct 7, 2024

Conversation

joyeeta26
Copy link
Contributor

@joyeeta26 joyeeta26 commented Oct 4, 2024 •
edited
Loading

Problem

Multiple substitutions specified in non-positional format of string resource

Fix

Added positioned arguments (%1$d, %2$d) to position_string
Fixes #588

Validations

Tested in fluent demo app

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • Automated Tests
  • Documentation and demo app examples
  • VoiceOver and Keyboard Accessibility
  • Internationalization and RTL layouts
  • Size classes and window sizes (notched devices, multitasking, different window sizes, etc)

@joyeeta26 joyeeta26 requested a review from a team as a code owner October 4, 2024 09:44
@joyeeta26 joyeeta26 merged commit eba8fbb into master Oct 7, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dhruv-Mishra Dhruv-Mishra Dhruv-Mishra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple substitutions specified in non-positional format of string resource string/position_string
2 participants
@joyeeta26 @Dhruv-Mishra