Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(Dropdown): inserting char at a cursor position will the cursor to end #897

Merged
merged 2 commits into from
Feb 14, 2019

Conversation

layershifter
Copy link
Member

@codecov
Copy link

codecov bot commented Feb 14, 2019

Codecov Report

Merging #897 into master will increase coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #897      +/-   ##
==========================================
+ Coverage   80.57%   80.59%   +0.02%     
==========================================
  Files         648      648              
  Lines        8335     8334       -1     
  Branches     1485     1484       -1     
==========================================
+ Hits         6716     6717       +1     
+ Misses       1604     1602       -2     
  Partials       15       15
Impacted Files Coverage Δ
...ackages/react/src/components/Dropdown/Dropdown.tsx 33.87% <33.33%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34d6b20...28b8f67. Read the comment docs.

Copy link
Collaborator

@silviuaavram silviuaavram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like a charm. thanks a bunch!

@layershifter layershifter merged commit ad29058 into master Feb 14, 2019
@layershifter layershifter deleted the fix/dropdown-focus branch February 18, 2019 12:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🧰 fix Introduces fix for broken behavior. 🚀 ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(dropdown): inserting char at a cursor position will always move the cursor to end
2 participants