This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silviuaavram
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
December 10, 2018 11:18
mnajdova
reviewed
Dec 11, 2018
mnajdova
reviewed
Dec 11, 2018
mnajdova
reviewed
Dec 11, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments/opinion. The changes are going in the right direction :)
silviuaavram
commented
Dec 13, 2018
silviuaavram
commented
Dec 13, 2018
silviuaavram
commented
Dec 13, 2018
miroslavstastny
changed the title
Single selection Dropdown
feat(Dropdown): Single selection
Dec 13, 2018
sophieH29
reviewed
Dec 17, 2018
sophieH29
reviewed
Dec 17, 2018
sophieH29
reviewed
Dec 17, 2018
sophieH29
reviewed
Dec 17, 2018
sophieH29
reviewed
Dec 17, 2018
Closed
mnajdova
reviewed
Jan 2, 2019
This reverts commit 97758c2.
silviuaavram
force-pushed
the
feat/selection-dropdown
branch
from
January 4, 2019 13:16
5e4dc81
to
4996260
Compare
mnajdova
reviewed
Jan 4, 2019
…-ui/react into feat/selection-dropdown
mnajdova
reviewed
Jan 8, 2019
mnajdova
reviewed
Jan 8, 2019
docs/src/examples/components/Dropdown/Types/DropdownExampleMultipleSearch.shorthand.tsx
Show resolved
Hide resolved
mnajdova
approved these changes
Jan 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 all issues are tracked, so we are save to merge this one!
layershifter
reviewed
Jan 8, 2019
layershifter
approved these changes
Jan 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Single Selection Dropdown. Created with a Button instead if an Input.
Behaviours:
Navigation with Screen Readers should work as well, with and without virtual cursor.
Button should be made shorthand, in a future task.
Added some improvement comments in #560 while working on this.