This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
feat(carousel): adding actionable items into carousel #2271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolaps33
requested review from
dvdzkwsk,
dzearing,
ecraig12345,
JasonGore,
jdhuntington,
kenotron,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
mnajdova
reviewed
Jan 24, 2020
| root: {}, | ||
| }, | ||
| root: { | ||
| stopPropagation: { |
There was a problem hiding this comment.
This looks like a strange name for keyAction. Can we use something related to the fact that navigation happend?
Perf comparison
Generated by 🚫 dangerJS |
| @@ -16,7 +17,11 @@ const carouselItemBehavior: Accessibility<CarouselItemProps> = props => ({ | |||
| }, | |||
|
|
|||
| keyActions: { | |||
| root: {}, | |||
| root: { | |||
| arrowKeysNavigationStopPropagation: { | |||
There was a problem hiding this comment.
Let's add a unit test for this.
It should check that left/right arrows sent to a child of the container (the visible item for instance, or a child of that visible item) should not move the slides.
There was a problem hiding this comment.
thanks :) for this catch. Tests added, as well a specification line in the top of file.
silviuaavram
approved these changes
Jan 29, 2020
…com/microsoft/fluent-ui-react into mituron/carousel-focusable-elements
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding actionable items into the carousel.
Trying to add button, buttons and toolbar to carousel slide.
If user is inside the carousel item and press right/left arrow key, then rotation of carousel was still working. This is fix with stopPropagation.
BE CAREFUL carousel is not fully accessible, related bugs reported in the ticket:
#2272