Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(docs): icons in docs not rendered properly #1625

Closed
wants to merge 29 commits into from

Conversation

lucivpav
Copy link
Contributor

This PR updates the outdated code snippets in theming section of docs. The icon colors were not set properly and the output did not match user's expectation. Relevant issue with error description: #1591.

Before:
image

After:
image

@codecov
Copy link

codecov bot commented Jul 12, 2019

Codecov Report

Merging #1625 into master will decrease coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1625      +/-   ##
==========================================
- Coverage   71.49%   71.28%   -0.21%     
==========================================
  Files         846      846              
  Lines        6945     6938       -7     
  Branches     2002     1982      -20     
==========================================
- Hits         4965     4946      -19     
- Misses       1974     1986      +12     
  Partials        6        6
Impacted Files Coverage Δ
...ages/react/test/specs/behaviors/testDefinitions.ts 87.39% <0%> (-5.58%) ⬇️
...b/accessibility/Behaviors/Tree/treeItemBehavior.ts 100% <0%> (ø) ⬆️
packages/react/src/components/Tree/TreeItem.tsx 76.31% <0%> (+1.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dc2027...4e88953. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 12, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@a5ff320). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1625   +/-   ##
=========================================
  Coverage          ?   70.07%           
=========================================
  Files             ?      867           
  Lines             ?     7429           
  Branches          ?     2161           
=========================================
  Hits              ?     5206           
  Misses            ?     2215           
  Partials          ?        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5ff320...fa251eb. Read the comment docs.

CHANGELOG.md Outdated Show resolved Hide resolved
@lucivpav
Copy link
Contributor Author

This was fixed by PR #1764. Closing this as it is no longer relevant.

@lucivpav lucivpav closed this Aug 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants