This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
fix(attachment): themeing and redline #1033
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x/attachment-themeing
…x/attachment-themeing
bcalvery
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
March 7, 2019 18:59
Codecov Report
@@ Coverage Diff @@
## master #1033 +/- ##
==========================================
- Coverage 82.45% 82.44% -0.02%
==========================================
Files 735 738 +3
Lines 8726 8743 +17
Branches 1235 1237 +2
==========================================
+ Hits 7195 7208 +13
- Misses 1515 1519 +4
Partials 16 16
Continue to review full report at Codecov.
|
docs/src/examples/components/Attachment/Variations/AttachmentActionableExample.shorthand.tsx
Show resolved
Hide resolved
bmdalex
approved these changes
Mar 20, 2019
docs/src/examples/components/Attachment/Variations/AttachmentActionableExample.shorthand.tsx
Show resolved
Hide resolved
packages/react/src/themes/teams-high-contrast/components/Attachment/attachmentVariables.ts
Outdated
Show resolved
Hide resolved
packages/react/src/themes/teams/components/Attachment/attachmentVariables.ts
Outdated
Show resolved
Hide resolved
packages/react/src/themes/teams-dark/components/Attachment/attachmentVariables.ts
Outdated
Show resolved
Hide resolved
packages/react/src/themes/teams-high-contrast/components/Attachment/attachmentVariables.ts
Outdated
Show resolved
Hide resolved
packages/react/src/themes/teams/components/Attachment/attachmentStyles.ts
Show resolved
Hide resolved
packages/react/src/themes/teams/components/Attachment/attachmentVariables.ts
Outdated
Show resolved
Hide resolved
codepretty
approved these changes
Apr 6, 2019
layershifter
approved these changes
Apr 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update to add dark and contrast theme files for Attachment and update the styling to match redlines.
Current problems with pxToRem mean that the these changes will not render correctly until pxToRem is fixed.
Before:
After:
Default (rest / hover / focus states)
Dark (rest / hover / focus states)
High contrast (rest / hover /focus states)