Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(attachment): themeing and redline #1033

Merged
merged 18 commits into from
Apr 8, 2019
Merged

Conversation

bcalvery
Copy link
Contributor

@bcalvery bcalvery commented Mar 7, 2019

This is an update to add dark and contrast theme files for Attachment and update the styling to match redlines.

Current problems with pxToRem mean that the these changes will not render correctly until pxToRem is fixed.

Before:
image

After:
Default (rest / hover / focus states)
image

Dark (rest / hover / focus states)
image

High contrast (rest / hover /focus states)
image

@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #1033 into master will decrease coverage by 0.01%.
The diff coverage is 73.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1033      +/-   ##
==========================================
- Coverage   82.45%   82.44%   -0.02%     
==========================================
  Files         735      738       +3     
  Lines        8726     8743      +17     
  Branches     1235     1237       +2     
==========================================
+ Hits         7195     7208      +13     
- Misses       1515     1519       +4     
  Partials       16       16
Impacted Files Coverage Δ
.../src/themes/teams-high-contrast/componentStyles.ts 100% <100%> (ø) ⬆️
...trast/components/Attachment/attachmentVariables.ts 100% <100%> (ø)
...c/themes/teams-high-contrast/componentVariables.ts 100% <100%> (ø) ⬆️
...-dark/components/Attachment/attachmentVariables.ts 100% <100%> (ø)
.../react/src/themes/teams-dark/componentVariables.ts 100% <100%> (ø) ⬆️
...kages/react/src/themes/teams-dark/siteVariables.ts 100% <100%> (ø) ⬆️
...teams/components/Attachment/attachmentVariables.ts 100% <100%> (ø) ⬆️
...contrast/components/Attachment/attachmentStyles.ts 42.85% <42.85%> (ø)
...es/teams/components/Attachment/attachmentStyles.ts 30.76% <66.66%> (+12.58%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d746c7...facd76e. Read the comment docs.

@codepretty codepretty merged commit 16b9fd0 into master Apr 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/attachment-themeing branch April 8, 2019 19:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants