Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

Button: type is working incorrecly #374

Closed
layershifter opened this issue Oct 19, 2018 · 2 comments
Closed

Button: type is working incorrecly #374

layershifter opened this issue Oct 19, 2018 · 2 comments
Assignees
Labels
🧰 bug Something isn't working good first issue Good for newcomers vsts Paired with ticket in vsts

Comments

@layershifter
Copy link
Member

layershifter commented Oct 19, 2018

Bug Report

Hi guys, I'm building now some stuff based on Stardust specifications and I found the design problem.

image

image

However, the type prop is reserved in button: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button

Steps

<Button content="Click here" type="reset" />

Expected Result

<button class="ui-button" aria-disabled="false" type="reset">
  <span class="ui-slot">Click here</span>
</button>

Actual Result

<button class="ui-button" aria-disabled="false">
  <span class="ui-slot">Click here</span>
</button>

Version

0.9.1

@hughreeling
Copy link
Contributor

hughreeling commented Oct 19, 2018 via email

@levithomason
Copy link
Member

+1 to boolean prop API for this

@levithomason levithomason added 🧰 bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Oct 20, 2018
@pkumarie2011 pkumarie2011 added the vsts Paired with ticket in vsts label Oct 23, 2018
@layershifter layershifter self-assigned this Nov 2, 2018
@layershifter layershifter removed the help wanted Extra attention is needed label Nov 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🧰 bug Something isn't working good first issue Good for newcomers vsts Paired with ticket in vsts
Projects
None yet
Development

No branches or pull requests

4 participants