Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup dependencies for ADX deployment #1151

Merged
merged 26 commits into from
Nov 23, 2024
Merged

Conversation

MSBrett
Copy link
Contributor

@MSBrett MSBrett commented Nov 20, 2024

πŸ› οΈ Description

Fixes a circular dependency in the deployment of Azure Data Explorer.

πŸ“‹ Checklist

πŸ”¬ How did you test this change?

  • 🀏 Lint tests
  • 🀞 PS -WhatIf / az validate
  • πŸ‘ Manually deployed + verified
  • πŸ’ͺ Unit tests
  • πŸ™Œ Integration tests

πŸ™‹β€β™€οΈ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🀏 The change is less than 20 lines of code.

πŸ“‘ Did you update docs/changelog.md?

  • βœ… Updated changelog (required for dev PRs)
  • ➑️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

πŸ“– Did you update documentation?

  • βœ… Public docs in docs (required for dev)
  • βœ… Internal dev docs in src (required for dev)
  • ➑️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@MSBrett MSBrett self-assigned this Nov 20, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Review πŸ‘€ PR that is ready to be reviewed label Nov 20, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Tool: FinOps hubs Data pipeline solution label Nov 20, 2024
@MSBrett MSBrett added Type: Bug πŸ› Something isn't working Status: πŸ”¬ Code review Issue is currently in code review with open PRs Resolution: Automerge This pull request can be merged automatically labels Nov 20, 2024
@MSBrett MSBrett marked this pull request as ready for review November 20, 2024 19:49
@MSBrett MSBrett enabled auto-merge (squash) November 20, 2024 19:50
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention πŸ‘‹ Issue or PR needs to be reviewed by the author or it will be closed due to no activity and removed Needs: Review πŸ‘€ PR that is ready to be reviewed labels Nov 20, 2024
@flanakin flanakin added this to the 2024-11 - November milestone Nov 20, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Review πŸ‘€ PR that is ready to be reviewed and removed Needs: Attention πŸ‘‹ Issue or PR needs to be reviewed by the author or it will be closed due to no activity labels Nov 20, 2024
@microsoft microsoft deleted a comment from flanakin Nov 22, 2024
@microsoft microsoft deleted a comment from flanakin Nov 22, 2024
@microsoft microsoft deleted a comment from flanakin Nov 22, 2024
@microsoft microsoft deleted a comment from flanakin Nov 22, 2024
@MSBrett MSBrett merged commit 018b059 into dev Nov 23, 2024
1 check passed
@MSBrett MSBrett deleted the msbrett/dev/ADXSetupDependencies branch November 23, 2024 16:22

@all-contributors please add MSBrett for code

Copy link
Contributor

@microsoft-github-policy-service[bot]

@MSBrett already contributed before to code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Review πŸ‘€ PR that is ready to be reviewed Resolution: Automerge This pull request can be merged automatically Status: πŸ”¬ Code review Issue is currently in code review with open PRs Tool: FinOps hubs Data pipeline solution Type: Bug πŸ› Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants