feat: auto detect date_type when not provided #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
|
Hey @laresbernardo thanks for the new feature! Can you please add a test in its own file in the test folder so we know it works for various types of data. Maybe using example data from the modeltime package. |
|
Thanks for the feedback @mitokic Added new test. |
|
Looking good to land? @mitokic |
|
@laresbernardo please review my comments and resolve them. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user may or may not specify
date_range. It's not needed given it can be calculated. By default I propose settingdate_type = NULLso it happens automatically instead of the current obligatory input. This update doesn't break past versions usage.