Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flips behavior, validate by default, opt out with Lenient #4720

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

brendankowitz
Copy link
Member

@brendankowitz brendankowitz commented Nov 12, 2024

Description

Take 2 on #4718. This allows the client to specify "Lenient" to opt out of validation...

This pull request includes several changes to improve the handling of search parameter validation in the FHIR server, particularly focusing on the differentiation between strict and lenient handling modes.

Enhancements to Handling Modes:

Test Adjustments:

Related issues

Addresses AB#130227

Testing

Unit tests.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@brendankowitz brendankowitz requested a review from a team as a code owner November 12, 2024 00:17
@brendankowitz brendankowitz added this to the S154 milestone Nov 12, 2024
@brendankowitz brendankowitz added Enhancement Enhancement on existing functionality. Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR KI-Breaking This is a known issue that causes a breaking change Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs labels Nov 12, 2024
@brendankowitz brendankowitz changed the title Flips default behavior, strict by default and client can opt out Flips default behavior, runs validation by default and client can opt out with "Lenient" specified Nov 12, 2024
@brendankowitz brendankowitz changed the title Flips default behavior, runs validation by default and client can opt out with "Lenient" specified Flips default behavior, runs validation by default and client can opt out with Lenient specified Nov 12, 2024
@brendankowitz brendankowitz changed the title Flips default behavior, runs validation by default and client can opt out with Lenient specified Flips default behavior, validation by default, client can opt out with Lenient Nov 12, 2024
@brendankowitz brendankowitz changed the title Flips default behavior, validation by default, client can opt out with Lenient Flips default behavior, validation by default, opt out with Lenient Nov 12, 2024
@brendankowitz brendankowitz changed the title Flips default behavior, validation by default, opt out with Lenient Flips behavior, validate by default, opt out with Lenient Nov 12, 2024
@brendankowitz brendankowitz enabled auto-merge (squash) November 12, 2024 18:26
@brendankowitz brendankowitz merged commit 7ea7204 into main Nov 13, 2024
51 of 60 checks passed
@brendankowitz brendankowitz deleted the personal/bkowitz/story-130227-v2 branch November 13, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Enhancement Enhancement on existing functionality. KI-Breaking This is a known issue that causes a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants