Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logging] Adding better logging to Bad Request #3856

Merged
merged 1 commit into from
May 15, 2024

Conversation

fhibf
Copy link
Contributor

@fhibf fhibf commented May 14, 2024

Adding better logging to Bad Request errors.
Sometimes the origin of the bad requests is not clear, and we need to rely on the customer feedback to support their scenarios.

In this PR, I'm trying to improve that by adding more clear logs to bad requests.

AB#120197

@fhibf fhibf requested a review from a team as a code owner May 14, 2024 19:13
@fhibf fhibf added Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Enhancement Enhancement on existing functionality. labels May 15, 2024
@fhibf fhibf added this to the S141 milestone May 15, 2024
@LTA-Thinking
Copy link
Collaborator

We may need to rework our monitor to not fire on warnings as frequently if these start producing a lot of issues.

@fhibf fhibf enabled auto-merge (squash) May 15, 2024 17:17
@fhibf fhibf modified the milestones: S141, S140, S142 May 15, 2024
@fhibf fhibf merged commit b90769b into main May 15, 2024
46 of 51 checks passed
@fhibf fhibf deleted the user/fernfe/betterLoggingOnBadRequests branch May 15, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Enhancement Enhancement on existing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants