Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add throw on failed initialization #3849

Merged
merged 3 commits into from
May 13, 2024
Merged

Add throw on failed initialization #3849

merged 3 commits into from
May 13, 2024

Conversation

LTA-Thinking
Copy link
Collaborator

@LTA-Thinking LTA-Thinking commented May 10, 2024 •
edited by azure-boards bot
Loading

Description

Adds a throw for failed search parameter initialization.

Related issues

Addresses AB#119273

Testing

Manual testing

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch

@LTA-Thinking LTA-Thinking added Bug Bug bug bug. Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs labels May 10, 2024
@LTA-Thinking LTA-Thinking added this to the S140 milestone May 10, 2024
@LTA-Thinking LTA-Thinking requested a review from a team as a code owner May 10, 2024 16:29
mikaelweave
mikaelweave previously approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@mikaelweave mikaelweave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦾

feordin
feordin reviewed May 10, 2024
View reviewed changes
src/Microsoft.Health.Fhir.Core/Features/Definition/SearchParameterDefinitionManager.cs
@@ -96,14 +96,17 @@ public async Task EnsureInitializedAsync(CancellationToken cancellationToken)
catch
{
_initialized = false;
throw;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this caught?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 279

mikaelweave
mikaelweave approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@mikaelweave mikaelweave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦾

@LTA-Thinking LTA-Thinking merged commit e390c4e into main May 13, 2024
47 checks passed
@LTA-Thinking LTA-Thinking deleted the personal/rojo/add-sp-init-throw branch May 13, 2024 17:39
@LTA-Thinking LTA-Thinking mentioned this pull request May 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feordin feordin feordin left review comments

@mikaelweave mikaelweave mikaelweave approved these changes

Assignees
No one assigned
Labels
Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Bug Bug bug bug.
Projects
None yet
Milestone
S140
Development

Successfully merging this pull request may close these issues.
3 participants
@LTA-Thinking @feordin @mikaelweave