-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for Bundle Routing #3822
Merged
Merged
Fixes for Bundle Routing #3822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhibf
previously approved these changes
Apr 23, 2024
src/Microsoft.Health.Fhir.Shared.Api/Features/Resources/Bundle/BundleRouter.cs
Fixed
Show fixed
Hide fixed
fhibf
previously approved these changes
Apr 23, 2024
src/Microsoft.Health.Fhir.Shared.Api/Features/Resources/Bundle/BundleRouter.cs
Fixed
Show fixed
Hide fixed
brendankowitz
force-pushed
the
dev/bundle-routing-fixes
branch
from
April 30, 2024 18:18
72d7f9c
to
033ee11
Compare
brendankowitz
force-pushed
the
dev/bundle-routing-fixes
branch
from
May 8, 2024 00:29
033ee11
to
10e79bb
Compare
brendankowitz
force-pushed
the
dev/bundle-routing-fixes
branch
from
May 8, 2024 23:31
10e79bb
to
63c64ce
Compare
brendankowitz
added
Bug
Bug bug bug.
Azure API for FHIR
Label denotes that the issue or PR is relevant to the Azure API for FHIR
Azure Healthcare APIs
Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs
labels
May 8, 2024
fhibf
approved these changes
May 8, 2024
src/Microsoft.Health.Fhir.Shared.Api/Features/Resources/Bundle/BundleRouter.cs
Dismissed
Show dismissed
Hide dismissed
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Azure API for FHIR
Label denotes that the issue or PR is relevant to the Azure API for FHIR
Azure Healthcare APIs
Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs
Bug
Bug bug bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes for Bundle Routing
This pull request includes changes to the
src/Microsoft.Health.Fhir.Shared.Api/Features/Resources/Bundle/BundleRouter.cs
andtest/Microsoft.Health.Fhir.Shared.Tests.E2E/Rest/BundleEdgeCaseTests.cs
files. The changes inBundleRouter.cs
involve adding new dependencies, modifying the constructor to accommodate these dependencies, and refactoring theRouteAsync
method. The changes inBundleEdgeCaseTests.cs
involve adding a new test case.Changes to
BundleRouter.cs
:BundleRouter
constructor to include new parameters:TemplateBinderFactory parameterPolicies
,IEnumerable<MatcherPolicy> matcherPolicies
, andEndpointSelector endpointSelector
. The constructor now also ensures these new parameters are not null.RouteAsync
method: The method is now asynchronous and includes changes to the logic for routing. The refactoring involves changes to the way route candidates are handled, the way the route endpoint is selected, and the way the selected endpoint is processed.Changes to
BundleEdgeCaseTests.cs
:System.Net
.WhenProcessingABundle_IfItContainsHistoryEndpointRequests_ThenReturnTheResourcesAsExpected
which tests the scenario where a bundle contains history endpoint requests.Related issues
Addresses #3821, AB#119362
Testing
Describe how this change was tested.
FHIR Team Checklist
Semver Change (docs)
Patch