Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Bundle Routing #3822

Merged
merged 7 commits into from
May 13, 2024
Merged

Fixes for Bundle Routing #3822

merged 7 commits into from
May 13, 2024

Conversation

brendankowitz
Copy link
Member

@brendankowitz brendankowitz commented Apr 23, 2024

Description

Fixes for Bundle Routing

This pull request includes changes to the src/Microsoft.Health.Fhir.Shared.Api/Features/Resources/Bundle/BundleRouter.cs and test/Microsoft.Health.Fhir.Shared.Tests.E2E/Rest/BundleEdgeCaseTests.cs files. The changes in BundleRouter.cs involve adding new dependencies, modifying the constructor to accommodate these dependencies, and refactoring the RouteAsync method. The changes in BundleEdgeCaseTests.cs involve adding a new test case.

Changes to BundleRouter.cs:

  • Modified the BundleRouter constructor to include new parameters: TemplateBinderFactory parameterPolicies, IEnumerable<MatcherPolicy> matcherPolicies, and EndpointSelector endpointSelector. The constructor now also ensures these new parameters are not null.
  • Refactored the RouteAsync method: The method is now asynchronous and includes changes to the logic for routing. The refactoring involves changes to the way route candidates are handled, the way the route endpoint is selected, and the way the selected endpoint is processed.

Changes to BundleEdgeCaseTests.cs:

  • Added a new dependency: System.Net.
  • Added a new test case: WhenProcessingABundle_IfItContainsHistoryEndpointRequests_ThenReturnTheResourcesAsExpected which tests the scenario where a bundle contains history endpoint requests.

Related issues

Addresses #3821, AB#119362

Testing

Describe how this change was tested.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch

fhibf
fhibf previously approved these changes Apr 23, 2024
@brendankowitz brendankowitz marked this pull request as ready for review April 23, 2024 17:34
@brendankowitz brendankowitz requested a review from a team as a code owner April 23, 2024 17:34
fhibf
fhibf previously approved these changes Apr 23, 2024
@brendankowitz brendankowitz added this to the S140 milestone May 8, 2024
@brendankowitz brendankowitz added Bug Bug bug bug. Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs labels May 8, 2024
@brendankowitz
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@brendankowitz brendankowitz merged commit 441fd71 into main May 13, 2024
47 checks passed
@brendankowitz brendankowitz deleted the dev/bundle-routing-fixes branch May 13, 2024 16:24
@brendankowitz brendankowitz linked an issue Jun 17, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Bug Bug bug bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

History request in Bundle returns 404
2 participants