New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for multi-platform public images #3809

Merged

mikaelweave merged 19 commits into main from personal/mikaelw/apple-silicone-image

Apr 25, 2024

Contributor

mikaelweave commented Apr 11, 2024 •

edited by azure-boards bot

Loading

Description

Builds and pushes multi-platform images in CI pipeline. This will allow users with ARM (Apple Silicone) machines to run the fhir-server containers natively.

Also part of this PR:

remove the uneeded compose file that's just building a single container

Related issues

Fixes #3648. AB#119514

Testing

Describe how this change was tested.

FHIR Team Checklist

Update the title of the PR to be succinct and less than 65 characters
Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
CI is green before merge
Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)


          Added support for multi-platform public images

bac9d51

Contributor Author

mikaelweave commented Apr 11, 2024

/azp run

azure-pipelines bot commented Apr 11, 2024

Azure Pipelines failed to run 1 pipeline(s).


          Added support for Azure Container Registry service connection

6a6f9af

Contributor Author

mikaelweave commented Apr 11, 2024

/azp run

azure-pipelines bot commented Apr 11, 2024

Azure Pipelines failed to run 1 pipeline(s).


          changed docker auth method

e49e834

Contributor Author

mikaelweave commented Apr 11, 2024

/azp run

azure-pipelines bot commented Apr 11, 2024

Azure Pipelines successfully started running 1 pipeline(s).


          changed to use azurecli for docker commands

bab2a5c

Contributor Author

mikaelweave commented Apr 11, 2024

/azp run

azure-pipelines bot commented Apr 11, 2024

Azure Pipelines successfully started running 1 pipeline(s).


          Fix script location docker build

f4cf067

Contributor Author

mikaelweave commented Apr 11, 2024

/azp run

azure-pipelines bot commented Apr 11, 2024

Azure Pipelines successfully started running 1 pipeline(s).


          fix docked build script type

cc05508

Contributor Author

mikaelweave commented Apr 11, 2024

/azp run

azure-pipelines bot commented Apr 11, 2024

Azure Pipelines successfully started running 1 pipeline(s).


          updated docker push shell

Contributor Author

mikaelweave commented Apr 11, 2024

/azp run

azure-pipelines bot commented Apr 11, 2024

Azure Pipelines successfully started running 1 pipeline(s).


          updated tags to lowercase

8b95f12

Contributor Author

mikaelweave commented Apr 11, 2024

/azp run

azure-pipelines bot commented Apr 11, 2024

Azure Pipelines successfully started running 1 pipeline(s).


          update lower case tag logic

f6fe0a0

Contributor Author

mikaelweave commented Apr 11, 2024

/azp run

azure-pipelines bot commented Apr 11, 2024

Azure Pipelines successfully started running 1 pipeline(s).


          update docker tag lowercase logic

ea9951a

Contributor Author

mikaelweave commented Apr 11, 2024

/azp run

azure-pipelines bot commented Apr 11, 2024

Azure Pipelines successfully started running 1 pipeline(s).

Contributor Author

mikaelweave commented Apr 12, 2024

/azp run

azure-pipelines bot commented Apr 12, 2024

Azure Pipelines successfully started running 1 pipeline(s).

mikaelweave added 2 commits

April 12, 2024 14:36


          updated azure.identity

a344421


          Merge branch 'main' into personal/mikaelw/apple-silicone-image

33a90f4

mikaelweave modified the milestones: S138, S139

mikaelweave added the Open source label

mikaelweave marked this pull request as ready for review

April 25, 2024 17:44

mikaelweave requested a review from a team as a code owner

April 25, 2024 17:44

mikaelweave added the Bug label


          remove unused compose location var

9ecba52

LTA-Thinking previously approved these changes

View reviewed changes


          fix dockerfile for multiarch

10c6fec

mikaelweave dismissed LTA-Thinking’s stale review via

10c6fec

April 25, 2024 19:43

mikaelweave added 5 commits

April 25, 2024 12:44


          match formatting in dockerfile

338d215


          undo formatting in dockerfile

e5bb62d


          add buildkit

d5046ac


          add missing targetarch parameter

4c911b3


          add targetarch to restore

9adade7

Contributor Author

mikaelweave commented Apr 25, 2024

Fixed the dockerfile 😄

LTA-Thinking approved these changes

View reviewed changes

mikaelweave merged commit 6427998 into main

49 checks passed

mikaelweave deleted the personal/mikaelw/apple-silicone-image branch

April 25, 2024 23:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Open source