Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom search example for sort by date #3646

Merged
merged 4 commits into from
Dec 22, 2023

Conversation

mikaelweave
Copy link
Contributor

Description

Add a REST doc showing how you can achieve sort on a custom Search Parameter.

Related issues

#3616

Testing

Ran through REST client in VSCode vs localhost SQL.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@mikaelweave mikaelweave requested a review from a team as a code owner December 21, 2023 23:24
@mikaelweave mikaelweave added this to the S130 milestone Dec 21, 2023
@mikaelweave mikaelweave added Area-Documents Area related to documents. Documentation Requires documentation. labels Dec 21, 2023
LTA-Thinking
LTA-Thinking previously approved these changes Dec 22, 2023
"resourceType": "Patient",
"extension": [
{
"url": "http://mycompany.org/fhir/StructureDefinition/test-bool",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do these extra examples show? I don't see a search parameter for them or examples using them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - updated to be more obvious that the "extra resource" is to show null behavior without :missing.

Copy link
Contributor

@rajithaalurims rajithaalurims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @mikaelweave and I discussed, we still need to fix SQL that is generating to get null values when missing modifier on sort parameter is specified.

@mikaelweave mikaelweave merged commit 19f3c5c into main Dec 22, 2023
6 checks passed
@mikaelweave mikaelweave deleted the personal/mikaelw/custom-sort-date-doc branch December 22, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Documents Area related to documents. Documentation Requires documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants