Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Pipeline: Fix Env Deployment Error #3610

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

mikaelweave
Copy link
Contributor

@mikaelweave mikaelweave commented Dec 1, 2023

Description

Currently, if you have a PR running and you push changes while the environment is deploying you can get transient errors because the existing PR pipeline is canceled and a new one is queued. The deployment will not succeed because an existing deployment with the same name is running.

I considered:

  • Making the name unique
  • Seeing if an existing deployment is there

In the end I checked for an existing deployment - should make the pipeline execute faster and less error prone to conflicts.

Error I was seeing

CleanShot 2023-12-01 at 10 36 13@2x

CleanShot 2023-12-01 at 10 05 52@2x

Testing

Describe how this change was tested.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@mikaelweave mikaelweave requested a review from a team as a code owner December 1, 2023 18:35
@mikaelweave mikaelweave added Bug Bug bug bug. Open source This change is only relevant to the OSS code or release. labels Dec 1, 2023
@mikaelweave mikaelweave added this to the S129 milestone Dec 1, 2023
@mikaelweave mikaelweave merged commit 2c7af62 into main Dec 1, 2023
6 of 10 checks passed
@mikaelweave mikaelweave deleted the personal/mikaelw/fix-env-provis-error branch December 1, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug bug bug. Open source This change is only relevant to the OSS code or release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants