Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed is searchable and sort for search param in reindex #3432

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Removed is searchable and sort for search param in reindex #3432

merged 2 commits into from
Aug 4, 2023

Conversation

PTaladay
Copy link
Collaborator

Description

Changing reindex to only look for search params to update by status only. The others were for old logic prior to status being changeable by the customer.

Related issues

Addresses [issue AB#105708].

Testing

Updated and ran through tests.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@PTaladay PTaladay added Bug Bug bug bug. Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs labels Jul 26, 2023
@PTaladay PTaladay added this to the S120 milestone Jul 26, 2023
@PTaladay PTaladay requested a review from a team as a code owner July 26, 2023 20:27
@PTaladay PTaladay changed the title Removed is searchable and sort for search param checks for reindex Removed is searchable and sort for search param in reindex Jul 26, 2023
SergeyGaluzo
SergeyGaluzo approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@SergeyGaluzo SergeyGaluzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@PTaladay PTaladay enabled auto-merge (squash) August 3, 2023 16:07
@PTaladay PTaladay merged commit 069eafd into main Aug 4, 2023
@PTaladay PTaladay deleted the personal/patalada/Bug105708 branch August 4, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyGaluzo SergeyGaluzo SergeyGaluzo approved these changes

@brendankowitz brendankowitz brendankowitz approved these changes

Assignees
No one assigned
Labels
Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Bug Bug bug bug.
Projects
None yet
Milestone
S120
Development

Successfully merging this pull request may close these issues.
3 participants
@PTaladay @brendankowitz @SergeyGaluzo