Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clone AccessControlContext for Bundle operations #3372

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Clone AccessControlContext for Bundle operations #3372

merged 1 commit into from
Jun 23, 2023

Conversation

feordin
Copy link
Contributor

@feordin feordin commented Jun 23, 2023 •
edited
Loading

Description

There was an issue with applying SMART restrictions in Bundle processing in that we didn't clone the access control context for the requests in a bundle. This makes sure that the SMART context is applied to all the requests.

Related issues

Addresses [issue AB#102910].

Testing

Manual test was added to the .http file for SMART

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@feordin feordin added Bug Bug bug bug. Bug-Security Security related bugs. Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs labels Jun 23, 2023
@feordin feordin added this to the S117 milestone Jun 23, 2023
@feordin feordin requested a review from a team as a code owner June 23, 2023 19:42
@feordin feordin merged commit 44b342e into main Jun 23, 2023
@feordin feordin deleted the personal/jaerwin/bundle-get-smart-bypass branch June 23, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajithaalurims rajithaalurims rajithaalurims approved these changes

Assignees
No one assigned
Labels
Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Bug Bug bug bug. Bug-Security Security related bugs.
Projects
None yet
Milestone
S117
Development

Successfully merging this pull request may close these issues.
2 participants
@feordin @rajithaalurims