Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding New Feature without the hyphen character for valid check #3355

Merged
merged 3 commits into from
Jun 16, 2023

Conversation

v-mserdar
Copy link
Contributor

Description

To handle when a label that is "New Feature" is added that it passes the metadata validator.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@v-mserdar v-mserdar added Enhancement Enhancement on existing functionality. Build labels Jun 15, 2023
@v-mserdar v-mserdar added this to the S117 milestone Jun 15, 2023
@v-mserdar v-mserdar requested a review from a team as a code owner June 15, 2023 21:28
LTA-Thinking
LTA-Thinking previously approved these changes Jun 15, 2023
@LTA-Thinking
Copy link
Collaborator

I feel we don't really need both. Would it make sense to just remove the one with the hyphen? The one without the hyphen has a description and looks better to a reader.

@v-mserdar
Copy link
Contributor Author

I feel we don't really need both. Would it make sense to just remove the one with the hyphen? The one without the hyphen has a description and looks better to a reader.

Can we just remove it without causing issues? What happens to ones that have that label attached?
If there's no issue with my questions, is it OK for me to just remove it from this page here?
https://github.com/microsoft/fhir-server/labels?page=2&sort=name-asc

@LTA-Thinking
Copy link
Collaborator

The label with the hyphen is only a day old, I'm the only one using it I think. I made it because my bulk delete PR wouldn't pass the check. We don't use the new feature tag much so I don't think it has come up before. I find it funny both of us ran into the same issue within a day of each other. Thanks for taking the better approach to fixing it :)

@v-mserdar v-mserdar merged commit d6ef034 into main Jun 16, 2023
@v-mserdar v-mserdar deleted the personal/v-mserdar/workflow_metadata_validation branch June 16, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Enhancement Enhancement on existing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants