Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Refactor for Missing External MI Case #3263

Merged
merged 3 commits into from
Apr 28, 2023

Conversation

ShaunDonn
Copy link
Contributor

Description

This PR addresses the issue of a user being unable to make a default template call unless they have the permissions/access token necessary for a custom template request configured. Default templates are currently stored in the code base, so no external permissions/tokens should be required to access these templates. This PR enables the use case for convert using default templates without external permissions/tokens configured by separating out the logic and dependency chains for custom and default template convert requests.

Related issues

Addresses issue #102114.

Testing

Unit tests were updated to align with the two use cases achieved by the updated logic. A FHIR server was also run locally and the control flow was verified for both a default and custom template request.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@ShaunDonn ShaunDonn added Bug Bug bug bug. Open source This change is only relevant to the OSS code or release. labels Apr 27, 2023
@ShaunDonn ShaunDonn added this to the S113 milestone Apr 27, 2023
@ShaunDonn ShaunDonn self-assigned this Apr 27, 2023
@ShaunDonn ShaunDonn requested a review from a team as a code owner April 27, 2023 18:52
@ShaunDonn ShaunDonn enabled auto-merge (squash) April 27, 2023 21:17
Copy link
Contributor

@ms-teli ms-teli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes.

@ShaunDonn ShaunDonn merged commit 3e83e50 into main Apr 28, 2023
@ShaunDonn ShaunDonn deleted the personal/sdonnelly/default-request-refactor branch April 28, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug bug bug. Open source This change is only relevant to the OSS code or release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants