Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Health Check] Limit of 30 seconds + retry #3224

Merged
merged 3 commits into from
Apr 12, 2023

Conversation

fhibf
Copy link
Contributor

@fhibf fhibf commented Apr 11, 2023

Limiting Gen1 Health Check to a 30 seconds operation, and allowing this operation to be retried in case of CosmosOperationCanceledException.

Related issues

  • Health Check taking more than 30 seconds to execute.

Testing

This change was tested locally. Multiple concurrent requests were executed to test the ability to handle multiple health check validations at the same time.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@fhibf fhibf requested a review from a team as a code owner April 11, 2023 20:45
@fhibf fhibf added Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Enhancement Enhancement on existing functionality. labels Apr 11, 2023
@fhibf fhibf added this to the 112 milestone Apr 11, 2023
@fhibf fhibf enabled auto-merge (squash) April 12, 2023 23:09
@fhibf fhibf merged commit 6076b7f into main Apr 12, 2023
@fhibf fhibf deleted the personal/fhibf/refactorHealthCheck branch April 12, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Enhancement Enhancement on existing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants