Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address flakey test #7044

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Address flakey test #7044

merged 4 commits into from
Dec 4, 2024

Conversation

janechu
Copy link
Collaborator

@janechu janechu commented Dec 4, 2024 •
edited
Loading

Pull Request

📖 Description

This PR attempts to address a flakey test in @microsoft/fast-ssr caused by the use of getComputedStyle.

✅ Checklist

General

  • I have included a change request file using $ npm run change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

chrisdholt
chrisdholt approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@chrisdholt chrisdholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you!

@janechu janechu merged commit a3c98e1 into master Dec 4, 2024
8 checks passed
@janechu janechu deleted the users/janechu/address-flakey-test branch December 4, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdholt chrisdholt chrisdholt approved these changes

@davatron5000 davatron5000 davatron5000 approved these changes

@radium-v radium-v Awaiting requested review from radium-v radium-v is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janechu @davatron5000 @chrisdholt