chore: comparisons to document.activeElement consider shadowRoot #6899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm. |
scomea
requested review from
EisenbergEffect,
chrisdholt,
bheston,
radium-v and
KingOfTac
as code owners
bheston
approved these changes
Jan 25, 2024
change/@microsoft-fast-foundation-015b56ec-8d8e-4573-9572-9822996f1245.json
Outdated
Show resolved
Hide resolved
radium-v
approved these changes
Feb 5, 2024
janechu
pushed a commit
that referenced
this pull request
Jun 10, 2024
* getRootActiveElement * Change files * comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 Description
In a number of places we check if
document.activeElementmatches some other element, but these checks don't always account for the possibility that the component is in a shadow root. This change adds a utility function to do that and updates a number of components to compare to the result of that function instead ofdocument.activeElement.🎫 Issues
ad-hoc
📑 Test Plan
Current tests work.
✅ Checklist
General
$ yarn changeComponent-specific