-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: run Playwright tests in all browsers #6876
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this update. I'm interested to know what is failing in Safari and to make sure we can figure that out because I feel that one of the benefits of a library like this is that it solves these cross-platform issues. I haven't seen any mention of actual bugs with tokens, but it would be really nice if we knew it was working via tests as well.
Regarding the delegates focus comments, we recently removed that from the registration on Adaptive Web Components. Many of the components are not best served with the current capabilities of this model. For instance, if there is extra whitespace on a custom element, the whole area causes a focus anyway. This was most prominent in the area to the right of the label above an input like on Text Field. We added a focus
override to correctly place focus. At least in Foundation this is only part of the test infrastructure and not the export.
0544142
to
9c53725
Compare
It looks like there are some issues in the Calendar tests in Webkit now. It seems to be adding characters to the I suspect the timeouts are spurious, though I still wish there were a way around this. |
9c53725
to
e132a36
Compare
e132a36
to
be81ac7
Compare
9d3d950
to
f7d2056
Compare
f7d2056
to
57f7d08
Compare
In order to get this PR to pass, I had to set up the build toolchain on Windows to address a Calendar bug. This bug only happens on newer versions of Webkit on Windows. I had to include it with this PR since the bug doesn't appear on the main branch. There's also a problem when using the most recent version of Playwright in |
Converting this back to a draft to split out some of the work. |
Pull Request
📖 Description
This PR updates the Playwright config in
fast-foundation
to run tests in Firefox and Webkit.This PR also updates Playwright to the latest version,
1.40.1
. The customhasAttribute
function has been replaced with Playwright's built-intoHaveAttribute
function, which now allows for checking the existence of an attribute without specifying a value.Some toolbar tests were failing, so I added a
focus()
method as a workaround.👩💻 Reviewer Notes
Some tests for Design Tokens are failing only in Webkit, so they're skipped for now. Toolbar tests were also failing in Firefox and Webkit, though I couldn't identify if this is a problem with Playwright or with our component. This may be related to these bugs:
📑 Test Plan
All tests should pass as expected.
Toolbar adds a
focus()
method, but it's marked as@internal
.✅ Checklist
General
$ yarn change
Component-specific