Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Missing syntax highlighting for css partials #6867

Closed
wants to merge 6 commits into from

Conversation

rizwan3d
Copy link

Pull Request

📖 Description

Missing syntax highlighting for CSS partials in FAST tagged templates extension.

🎫 Issues

Regex only has CSS for consideration for template.
fix: Missing syntax highlighting for css partials in FAST tagged templates extension #6380

✅ Checklist

General

  • I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

@rizwan3d
Copy link
Author

rizwan3d commented Nov 16, 2023

@microsoft-github-policy-service agree

@rizwan3d rizwan3d requested a review from KingOfTac November 16, 2023 20:06
@radium-v
Copy link
Collaborator

I think since css.partial allows for just property lists (instead of selectors followed by property lists), this may need some more work to function properly. There aren't many uses of css.partial in the monorepo but here's one from a test:

const partial = css.partial`color: ${new myDirective}`;

This pattern would need to be defined on its own so it can include the weirdly named source.css#rule-list-innards pattern.

@rizwan3d rizwan3d requested a review from radium-v November 17, 2023 11:09
@radium-v
Copy link
Collaborator

This needs to be held since the vscode-css package can either handle key-value pairs, or selectors, but not both at the same time.

microsoft/vscode-css#9

Copy link
Collaborator

@radium-v radium-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding for further investigation

@rizwan3d rizwan3d requested a review from radium-v December 3, 2023 05:42
@radium-v radium-v marked this pull request as draft January 5, 2024 23:13
@rizwan3d rizwan3d marked this pull request as ready for review May 12, 2024 07:18
@rizwan3d rizwan3d requested a review from janechu as a code owner May 12, 2024 07:18
@janechu
Copy link
Collaborator

janechu commented May 22, 2024

Closing this PR as stale and obsolete with the migration of the package to @radium-v, see #6964.

@janechu janechu closed this May 22, 2024
@janechu janechu added the closed:moved An issue that was moved to another repo. label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed:moved An issue that was moved to another repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants