Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foundation: Update Slider templates #6800

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

bheston
Copy link
Collaborator

@bheston bheston commented Aug 8, 2023

Pull Request

📖 Description

As part of the next major release of fast-foundation, we wanted to do a complete review of the component templates and align the structure and naming as much as possible.

This PR is split from #6286 and updates the Slider and Slider Label templates.

Before on the left, update on the right. "C" = class, "P" = part, "R" = role, "S" = slot. 💔 = potentially style-breaking.

Slider

  • 💔 Rename “track-container” part to “track”
  • Add "thumb" class and part wrapper for "thumb" slot
  • 💔 Remove duplicate class (orientation) on root template element

Slider

Slider label

  • 💔 Flatten “container” and “root”
  • 💔 Rename “label” to “content”
  • Add part to "mark" and "content"

Slider label

👩‍💻 Reviewer Notes

Review the Storybook site, or the illustrations of the components before and after, compared to the changes in code.

📑 Test Plan

Tested via comparison against proposal and in Storybook.

✅ Checklist

General

  • I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

Copy link
Collaborator

@scomea scomea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the branch locally, didn't see any issues.

@bheston bheston force-pushed the users/bheston/foundation-slider-update branch from 8b8f9ea to d734515 Compare September 24, 2023 22:35
@bheston bheston force-pushed the users/bheston/foundation-slider-update branch from d734515 to 76e5763 Compare February 4, 2024 20:59
@bheston bheston requested a review from radium-v as a code owner February 4, 2024 20:59
@bheston bheston force-pushed the users/bheston/foundation-slider-update branch from 3bf01b9 to 7af0635 Compare February 5, 2024 04:46
@bheston bheston force-pushed the users/bheston/foundation-slider-update branch from 7af0635 to 7d8ec96 Compare March 7, 2024 20:48
@bheston bheston merged commit 2ba8729 into master Mar 7, 2024
9 of 10 checks passed
@bheston bheston deleted the users/bheston/foundation-slider-update branch March 7, 2024 21:16
janechu pushed a commit that referenced this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants