Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foundation: Update Progress templates #6799

Closed
wants to merge 5 commits into from

Conversation

bheston
Copy link
Collaborator

@bheston bheston commented Aug 8, 2023

Pull Request

📖 Description

As part of the next major release of fast-foundation, we wanted to do a complete review of the component templates and align the structure and naming as much as possible.

This PR is split from #6286 and updates the Progress and Progress Ring templates.

Before on the left, update on the right. "C" = class, "P" = part, "R" = role, "S" = slot. 💔 = potentially style-breaking.

Progress

  • 💔 Rename "progress" container to "determinate" and "indeterminate"
  • 💔 Change “determinate” div to slot
  • 💔 Remove “indeterminateIndicator2” option

Progress

Progress ring

  • 💔 Follow Progress structure

Progress ring

👩‍💻 Reviewer Notes

Review the Storybook site, or the illustrations of the components before and after, compared to the changes in code.

📑 Test Plan

Tested via comparison against proposal and in Storybook.

✅ Checklist

General

  • I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

Copy link
Collaborator

@scomea scomea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the branch locally, didn't notice any issues.

@bheston bheston force-pushed the users/bheston/foundation-progress-update branch from 66ce4ad to d398f0e Compare September 24, 2023 22:44
@bheston bheston force-pushed the users/bheston/foundation-progress-update branch from d398f0e to fcd5e40 Compare December 13, 2023 04:20
@bheston bheston force-pushed the users/bheston/foundation-progress-update branch from 2d49517 to e2ee545 Compare March 9, 2024 19:38
@bheston bheston requested a review from radium-v as a code owner March 9, 2024 19:38
@janechu
Copy link
Collaborator

janechu commented Jun 14, 2024

Closing this as we're closing out work on foundation per #6951, and this seems like it will potentially break downstream consumers.

@janechu janechu closed this Jun 14, 2024
@janechu janechu deleted the users/bheston/foundation-progress-update branch June 14, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants