Foundation: Update Badge and Breadcrumb templates #6797
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
As part of the next major release of fast-foundation, we wanted to do a complete review of the component templates and align the structure and naming as much as possible.
This PR is split from #6286 and adds Start and End slots to Badge and Breadcrumb.
Before on the left, update on the right. "C" = class, "P" = part, "R" = role, "S" = slot. 💔 = potentially style-breaking.
Badge
start
andend
slotscontrol
span tocontent
Breadcrumb
start
andend
slotsBreadcrumb item
listitem
div to template👩💻 Reviewer Notes
Review the Storybook site, or the illustrations of the components before and after, compared to the changes in code.
📑 Test Plan
Tested via comparison against proposal and in Storybook.
✅ Checklist
General
$ yarn change
Component-specific