Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foundation: Update Badge and Breadcrumb templates #6797

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

bheston
Copy link
Collaborator

@bheston bheston commented Aug 7, 2023

Pull Request

📖 Description

As part of the next major release of fast-foundation, we wanted to do a complete review of the component templates and align the structure and naming as much as possible.

This PR is split from #6286 and adds Start and End slots to Badge and Breadcrumb.

Before on the left, update on the right. "C" = class, "P" = part, "R" = role, "S" = slot. 💔 = potentially style-breaking.

Badge

  • Add start and end slots
  • 💔 Rename control span to content

Badge

Breadcrumb

  • Add start and end slots

Breadcrumb

Breadcrumb item

  • 💔 Flatten listitem div to template

Breadcrumb item

👩‍💻 Reviewer Notes

Review the Storybook site, or the illustrations of the components before and after, compared to the changes in code.

📑 Test Plan

Tested via comparison against proposal and in Storybook.

✅ Checklist

General

  • I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

@bheston bheston self-assigned this Aug 7, 2023
@bheston bheston force-pushed the users/bheston/foundation-start-end-add branch from 14e43e4 to b842f22 Compare August 8, 2023 01:49
@bheston bheston force-pushed the users/bheston/foundation-start-end-add branch from 172172f to 24c12c9 Compare September 24, 2023 20:08
@bheston bheston force-pushed the users/bheston/foundation-start-end-add branch from 24c12c9 to ca299ed Compare December 13, 2023 05:00
@bheston bheston force-pushed the users/bheston/foundation-start-end-add branch from ca299ed to d839e22 Compare January 25, 2024 05:11
@bheston bheston merged commit daff330 into master Jan 25, 2024
5 checks passed
@bheston bheston deleted the users/bheston/foundation-start-end-add branch January 25, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants