fix: picker should work in a shadow root #6669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scomea
requested review from
EisenbergEffect,
chrisdholt,
nicholasrice and
janechu
as code owners
chrisdholt
reviewed
Mar 10, 2023
change/@microsoft-fast-foundation-9ba63b54-21bc-47e3-a176-545c43124446.json
Outdated
Show resolved
Hide resolved
chrisdholt
approved these changes
Mar 10, 2023
…43124446.json Co-authored-by: Chris Holt <[email protected]>
KingOfTac
approved these changes
Mar 10, 2023
janechu
pushed a commit
that referenced
this pull request
Jun 10, 2024
* get right active element for root * Change files * prettier * Update change/@microsoft-fast-foundation-9ba63b54-21bc-47e3-a176-545c43124446.json Co-authored-by: Chris Holt <[email protected]> --------- Co-authored-by: Chris Holt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Picker was always looking at the document root for the active element which broke when it was in a shadow root.
🎫 Issues
ad-hoc
✅ Checklist
General
$ yarn changeComponent-specific