chore: import icons for fast-foundation stories #6607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bheston
requested review from
EisenbergEffect,
chrisdholt,
nicholasrice and
janechu
as code owners
janechu
approved these changes
Jan 17, 2023
change/@microsoft-fast-foundation-12c0b3c8-515f-4b6f-a47b-0d6124919595.json
Outdated
Show resolved
Hide resolved
chrisdholt
reviewed
Jan 17, 2023
Comment on lines
+27
to
+33
| { | ||
| test: /\.svg$/, | ||
| loader: "svg-inline-loader", | ||
| options: { | ||
| removeSVGTagAttrs: false, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
@radium-v do you know if we're setup on a version where we can leverage the statics/builtins from storybook?
There was a problem hiding this comment.
I considered updating to use the assets model but this was a known entity.
chrisdholt
requested changes
Jan 17, 2023
packages/web-components/fast-foundation/src/accordion-item/stories/accordion-item.register.ts
Outdated
Show resolved
Hide resolved
bheston
force-pushed
the
users/bheston/import-foundation-story-icons
branch
from
bffda22 to
e2511ba
Compare
awentzel
approved these changes
Jan 21, 2023
chrisdholt
reviewed
Jan 25, 2023
chrisdholt
reviewed
Jan 27, 2023
bheston
force-pushed
the
users/bheston/import-foundation-story-icons
branch
from
bd0b187 to
79e47a0
Compare
chrisdholt
approved these changes
Jan 30, 2023
janechu
pushed a commit
that referenced
this pull request
Jun 10, 2024
* Import icons for fast-foundation stories * Change files * Review comments * Switched from Fluent package to local svg * Fix yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Add icons or change from inline svg to imported svg icons for
fast-foundationstories.This work comes from the foundation template update work and will further simplify that. It's needed for proper testing of components that expect a provided icon.
✅ Checklist
General
$ yarn change⏭ Next Steps
Finish switching over remaining icons in the foundation template update where some styles also change to not directly target expected
classorpart.