-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(foundation): remove readonly from Slider #6481
Conversation
@microsoft-github-policy-service agree company="Vonage" |
change/@microsoft-fast-foundation-3285b619-2c39-4c8f-98c8-b839c81f85ea.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR seems very similar in nature to the one we have for radio groups that makes the same set of changes. Like that one, I want to make sure we don't have a bug in the key handler. Shouldn't it be checking for disabled state like the mouse handler or does the platform handle that automatically?
📖 Description
This PR removes the
readonly
state for the Slider component in an effort to keep it close to theinput range
's behavior.The specs for the latter can be found here (see the 'Bookkeeping details' part after the examples).
See PR #6438 for a similar update to the radio button.
👩💻 Reviewer Notes
As it is a removal, the change is pretty straightforward. Code/tests/doc should be covered.
slider-label
should not be affected as far as I can tell.✅ Checklist
General
$ yarn change
Component-specific