Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FASTElement 2.0 #5282

Merged
merged 137 commits into from
May 31, 2022
Merged

FASTElement 2.0 #5282

merged 137 commits into from
May 31, 2022

Conversation

EisenbergEffect
Copy link
Contributor

@EisenbergEffect EisenbergEffect commented Oct 13, 2021

Pull Request

πŸ“– Description

Next major version of FASTElement with SSR support and performance improvements.

🎫 Issues

See the FastElement 2.0 milestone.

πŸ‘©β€πŸ’» Reviewer Notes

Individual PRs to the 2.0 branch have been reviewed.

πŸ“‘ Test Plan

Keep existing tests working.

βœ… Checklist

General

  • I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

⏭ Next Steps

Additional work will proceed on the main branch after this merge, fixing issues, adding a few features, polishing APIs, and updating documentation.

@EisenbergEffect EisenbergEffect changed the title Features/fast element 2 FASTElement 2.0 Oct 13, 2021
@EisenbergEffect EisenbergEffect added this to the FASTElement 2.0 milestone Oct 13, 2021
@EisenbergEffect EisenbergEffect force-pushed the features/fast-element-2 branch 2 times, most recently from 31c9901 to b48cf3b Compare February 10, 2022 13:35
@nicholasrice nicholasrice force-pushed the features/fast-element-2 branch from 3ae251a to 7036e33 Compare April 7, 2022 21:14
@ghost
Copy link

ghost commented Apr 29, 2022

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ EisenbergEffect sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@nicholasrice nicholasrice force-pushed the features/fast-element-2 branch 2 times, most recently from 613715e to 8d37630 Compare May 5, 2022 17:25
@github-actions
Copy link

github-actions bot commented May 5, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-sand-03fe10e10-5282.centralus.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented May 5, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-ocean-0b7ce3410-5282.centralus.azurestaticapps.net

@nicholasrice nicholasrice force-pushed the features/fast-element-2 branch from 8d37630 to caaa685 Compare May 9, 2022 19:19
@github-actions
Copy link

github-actions bot commented May 9, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-sand-03fe10e10-5282.centralus.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented May 9, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-ocean-0b7ce3410-5282.centralus.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-sand-03fe10e10-5282.centralus.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-ocean-0b7ce3410-5282.centralus.azurestaticapps.net

10 similar comments
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-ocean-0b7ce3410-5282.centralus.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-ocean-0b7ce3410-5282.centralus.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-ocean-0b7ce3410-5282.centralus.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-ocean-0b7ce3410-5282.centralus.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-ocean-0b7ce3410-5282.centralus.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-ocean-0b7ce3410-5282.centralus.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-ocean-0b7ce3410-5282.centralus.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-ocean-0b7ce3410-5282.centralus.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-ocean-0b7ce3410-5282.centralus.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-ocean-0b7ce3410-5282.centralus.azurestaticapps.net

EisenbergEffect and others added 13 commits May 31, 2022 12:14
… (v2) (#6006)

* fix(fast-element): do not notify splices for changes pre-subscription

* Change files

Co-authored-by: EisenbergEffect <[email protected]>
* remove private field from package.json

* Change files

Co-authored-by: nicholasrice <[email protected]>
* chore: configure fast-element for internal stripping

* chore: configure fast-foundation for internals stripping

* chore: configure fast-ssr for internals stripping

* chore: configure fast-router for internals stripping

* chore: finish cleanup of internals stripping

* Change files

Co-authored-by: EisenbergEffect <[email protected]>
* change activeindicator attribute in tabs to hide-active-indicator to better support boolean attribute behavior

* Change files
* update api extractor and typescript to use the latest versions

* Change files
* change trapFocus on dialog to noFocusTrap to better support boolean attributes

* Change files
* update npmignore file w/ new project structure

* Change files

Co-authored-by: nicholasrice <[email protected]>
* add files and foundation dev dependency

* fixing issue where getter and static property "attributes" was causing static to clobber the getter

* removing style utilities

* adding uninstall dom shim test util

* adding foundation DOM shim

* Revert "removing style utilities"

This reverts commit bfa5816.

* deprecate styling utilities and hard-code focus-visible

* fixing errors in foundation element rendering

* cleans up foundation-dom-shim spec file

* adding un-install dom shim

* adding exports field for foundation shim and install-foundation-shim

* Change files

* remove foundation DOM shim and integrate it into minimal DOM shim

* fixing deprecation notice

* remove uninstall-dom-shim because it is no longer needed

* removing foundation DOM shim

Co-authored-by: nicholasrice <[email protected]>
* docs: update a few readme files

* Change files

Co-authored-by: EisenbergEffect <[email protected]>
… improvements (#6030)

* chore: rebase to accept typescript and api-extractor updates

* feat: enable subscribing deeply to observables

* feat: introduce Disposable interface and use throughout fast-element

* test: add initial tests for makeObservable utility

* test: add initial tests for the watch utility

* feat: initial prototype of useState() and useEffect() hooks

* test: add tests for the useState() hook

* refactor: remove disconnect from BindingObserve and add  sync updates

* chore: fixing up file extension in tests and for disposable

* chore: various fixes for Node16 and package exports

* chore: update core web component library webpack and karma config

* Change files

* fix: temporary fix for site build

* chore: fix adaptive-ui build and test

* Change files

* Users/chhol/remove unnecessary site utilities (#6036)

* remove site util source directory and update website webpack loaders for assets

* fixing fast-foundation dependency version to install workspace version

* fixing test errors in fast-site-utilities

* removing eslint from site-utilties

* fixing path to spect files in adaptive-ui

* fixing color-explorer build

* remove babel-loader from website

Co-authored-by: nicholasrice <[email protected]>

* Change files

* chore: remove prettier from site-utilities

Co-authored-by: EisenbergEffect <[email protected]>
Co-authored-by: Chris Holt <[email protected]>
Co-authored-by: nicholasrice <[email protected]>
@EisenbergEffect EisenbergEffect force-pushed the features/fast-element-2 branch from e5b97ac to f610ded Compare May 31, 2022 17:11
@EisenbergEffect
Copy link
Contributor Author

DO NOT MERGE YET.

EisenbergEffect and others added 5 commits May 31, 2022 13:58
* add missing dependency to fast-animation

* adding missing dependency to fast-color-explorer

* update webpack in fast-animation

* Change files

* fix webpack config

Co-authored-by: nicholasrice <[email protected]>
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-ocean-0b7ce3410-5282.centralus.azurestaticapps.net

1 similar comment
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-ocean-0b7ce3410-5282.centralus.azurestaticapps.net

@chrisdholt chrisdholt merged commit 4699e77 into master May 31, 2022
@chrisdholt chrisdholt deleted the features/fast-element-2 branch May 31, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants