chore: example radios on website should be wrapped in a radiogroup #3681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdholt
force-pushed
the
users/chhol/radios-should-be-wrapped-in-group
branch
from
9562e26 to
d193121
Compare
chrisdholt
force-pushed
the
users/chhol/radios-should-be-wrapped-in-group
branch
from
d193121 to
230a5e0
Compare
EisenbergEffect
approved these changes
Aug 11, 2020
janechu
approved these changes
Aug 11, 2020
| @@ -70,6 +71,7 @@ export const FastFrameTemplate = html<FastFrame>` | |||
| </fast-radio-group> | |||
| <label for="accent-color-pickers">Accent color</label> | |||
| <fast-radio-group | |||
| class="swatches" | |||
There was a problem hiding this comment.
Suggested change
| class="swatches" | |
| class="swatches" |
There was a problem hiding this comment.
interesting - I don't recall formatting like this...and prettier should catch. I'm going to run it again.
chrisdholt
force-pushed
the
users/chhol/radios-should-be-wrapped-in-group
branch
from
4686302 to
5f335d2
Compare
chrisdholt
force-pushed
the
users/chhol/radios-should-be-wrapped-in-group
branch
from
5f335d2 to
83c13da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the example radios were not wrapped in a radiogroup and resulted in inaccessable behavior.
Motivation & context
closes #3676
Issue type checklist
Is this a breaking change?
Adding or modifying component(s) in
@microsoft/fast-componentschecklistProcess & policy checklist