Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct radio corner radius value #3655

Merged
merged 3 commits into from
Aug 10, 2020

Conversation

chrisdholt
Copy link
Member

Description

This PR corrects the visual design of the FAST radios.

Motivation & context

Somewhere between v2 and v3 of the homepage design specs, the corner radius for the radio buttons shifted to align with checkboxes. From a visual design standpoint, this is incorrect. Further, from an accessibility standpoint, this is even more problematic. The controls appear to the be same and have no distinct difference; this PR corrects the radios to be circular at all times solving both the visual design problem and the accessibility issue presented by this appearing the same as a checkbox.

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Copy link
Contributor

@EisenbergEffect EisenbergEffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it better to do

Copy link
Contributor

@marjonlynch marjonlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2020-08-10 at 10 31 16 AM

looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants