-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add checks for minimum and maximum out of bounds and add tests for the number type #3652
Merged
janechu
merged 6 commits into
master
from
users/janechu/add-number-testing-for-permutator
Aug 11, 2020
Merged
fix: add checks for minimum and maximum out of bounds and add tests for the number type #3652
janechu
merged 6 commits into
master
from
users/janechu/add-number-testing-for-permutator
Aug 11, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janechu
requested review from
chrisdholt,
EisenbergEffect and
nicholasrice
as code owners
August 8, 2020 04:08
janechu
force-pushed
the
users/janechu/add-number-testing-for-permutator
branch
from
August 8, 2020 04:09
eede445
to
a8b17a5
Compare
awentzel
reviewed
Aug 10, 2020
awentzel
reviewed
Aug 10, 2020
awentzel
reviewed
Aug 10, 2020
awentzel
approved these changes
Aug 10, 2020
EisenbergEffect
approved these changes
Aug 10, 2020
janechu
force-pushed
the
users/janechu/add-number-testing-for-permutator
branch
2 times, most recently
from
August 10, 2020 22:10
07cfbf7
to
2f41e23
Compare
janechu
force-pushed
the
users/janechu/add-number-testing-for-permutator
branch
from
August 10, 2020 22:28
2f41e23
to
71969e6
Compare
This was referenced Aug 18, 2021
This was referenced Sep 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds checks for minimum and maximum to set the random numbers generated with a range of 100. Adds a check if the minimum is greater than maximum (which should fail validation checks regardless) a number is returned. Adds unit testing for the number type.
Motivation & context
Resolves #3565
Issue type checklist
Is this a breaking change?
Adding or modifying component(s) in
@microsoft/fast-components
checklistProcess & policy checklist