Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add checks for minimum and maximum out of bounds and add tests for the number type #3652

Merged
merged 6 commits into from
Aug 11, 2020

Conversation

janechu
Copy link
Collaborator

@janechu janechu commented Aug 8, 2020

Description

Adds checks for minimum and maximum to set the random numbers generated with a range of 100. Adds a check if the minimum is greater than maximum (which should fail validation checks regardless) a number is returned. Adds unit testing for the number type.

Motivation & context

Resolves #3565

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@janechu janechu self-assigned this Aug 8, 2020
@janechu janechu force-pushed the users/janechu/add-number-testing-for-permutator branch from eede445 to a8b17a5 Compare August 8, 2020 04:09
@janechu janechu force-pushed the users/janechu/add-number-testing-for-permutator branch 2 times, most recently from 07cfbf7 to 2f41e23 Compare August 10, 2020 22:10
@janechu janechu force-pushed the users/janechu/add-number-testing-for-permutator branch from 2f41e23 to 71969e6 Compare August 10, 2020 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add testing for the permutator number generation
3 participants