-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adds API docs for fast-colors and fast-animation #3359
Merged
nicholasrice
merged 14 commits into
master
from
users/nirice/add-api-extractor-to-colors-and-animation
Jun 25, 2020
Merged
chore: adds API docs for fast-colors and fast-animation #3359
nicholasrice
merged 14 commits into
master
from
users/nirice/add-api-extractor-to-colors-and-animation
Jun 25, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasrice
requested review from
awentzel,
chrisdholt,
EisenbergEffect and
Falkicon
as code owners
June 23, 2020 23:34
chrisdholt
approved these changes
Jun 24, 2020
EisenbergEffect
approved these changes
Jun 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I admit to rubber stamping this a bit since it was so large of a docs PR. I scanned everything but pretty quickly.
@@ -254,8 +257,10 @@ async function copyArticleMarkdown() { | |||
// Copy the api.json files from the web-components packages. | |||
async function copyAPI() { | |||
for (const package of packages) { | |||
const packageDir = glob.sync(path.resolve(`../../packages/**/${package}`))[0]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
nicholasrice
deleted the
users/nirice/add-api-extractor-to-colors-and-animation
branch
June 25, 2020 02:13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change wires up API docs for
@microsoft/fast-animation
and@microsoft/fast-colors
. It also integrates those API docs intosites/website
in the API docs sidebar section.Motivation & context
Issue type checklist
Is this a breaking change?
Adding or modifying component(s) in
@microsoft/fast-components
checklistProcess & policy checklist