Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: inject website bundle script into the head to prevent flash of unstyled content #3358

Merged
merged 3 commits into from
Jun 23, 2020

Conversation

chrisdholt
Copy link
Member

Description

This PR shifts the bundle for the website homepage from the end of the body to the head. Doing so will block the rendering of the page for the bundle which will prevent a flash of unstyled content and ensure that the web components and styles making up the page load together.

Motivation & context

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@chrisdholt chrisdholt merged commit cece0e5 into master Jun 23, 2020
@chrisdholt chrisdholt deleted the users/chhol/inject-script-into-website-head branch June 23, 2020 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants