Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: grammar and style corrections #3354

Merged
merged 11 commits into from
Jun 23, 2020
Merged

docs: grammar and style corrections #3354

merged 11 commits into from
Jun 23, 2020

Conversation

EisenbergEffect
Copy link
Contributor

Description

This PR updates all the markdown and readme files with fixes from a basic grammar pass along with corrections based on the style guide.

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@EisenbergEffect EisenbergEffect changed the title Users/eisenbergeffect/docs grammar docs: grammar and style corrections Jun 23, 2020
@EisenbergEffect EisenbergEffect mentioned this pull request Jun 23, 2020
Closed
35 tasks
chrisdholt
chrisdholt approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member

@chrisdholt chrisdholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small suggestion

@EisenbergEffect
Copy link
Contributor Author

Requesting review from @Falkicon and @chrisdholt on this PR. In particular, have a look at the FAQ's questions on the difference between FAST, Fluent, and Fluent UI. Let me know if I need to reword any of that.

chrisdholt
chrisdholt approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member

@chrisdholt chrisdholt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I thought I signed off on this with my suggestion. Let me look at the FAQ quickly though.

@EisenbergEffect
Copy link
Contributor Author

@chrisdholt I re-requested a review since I changed the FAQ section.

@EisenbergEffect EisenbergEffect merged commit 77558dc into master Jun 23, 2020
@EisenbergEffect EisenbergEffect deleted the users/eisenbergeffect/docs-grammar branch June 23, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awentzel awentzel awentzel approved these changes

@chrisdholt chrisdholt chrisdholt approved these changes

@Falkicon Falkicon Awaiting requested review from Falkicon Falkicon is a code owner

@janechu janechu Awaiting requested review from janechu janechu is a code owner

@nicholasrice nicholasrice Awaiting requested review from nicholasrice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EisenbergEffect @chrisdholt @awentzel