Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: constrain site-section-header in non-mobile width #3347

Merged
merged 2 commits into from
Jun 22, 2020
Merged

chore: constrain site-section-header in non-mobile width #3347

merged 2 commits into from
Jun 22, 2020

Conversation

freefaller69
Copy link
Contributor

Description

Constrain site-section-headers to 900px width at non-mobile breakpoint

Motivation & context

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@freefaller69 freefaller69 self-assigned this Jun 19, 2020
@freefaller69 freefaller69 force-pushed the users/v-mbenso/contain-section-header branch from 52df452 to e642e99 Compare June 22, 2020 15:45
@radium-v radium-v mentioned this pull request Jun 22, 2020
Closed
35 tasks
@freefaller69 freefaller69 force-pushed the users/v-mbenso/contain-section-header branch from e642e99 to bc0710d Compare June 22, 2020 16:28
@freefaller69 freefaller69 force-pushed the users/v-mbenso/contain-section-header branch from bc0710d to c6844b4 Compare June 22, 2020 16:55
@freefaller69 freefaller69 force-pushed the users/v-mbenso/contain-section-header branch from c6844b4 to c200ca0 Compare June 22, 2020 17:23
@freefaller69 freefaller69 merged commit 7366eef into master Jun 22, 2020
@freefaller69 freefaller69 deleted the users/v-mbenso/contain-section-header branch June 22, 2020 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eljefe223 eljefe223 eljefe223 left review comments

@SamanthaAO SamanthaAO SamanthaAO approved these changes

@nicholasrice nicholasrice nicholasrice approved these changes

@chrisdholt chrisdholt Awaiting requested review from chrisdholt chrisdholt is a code owner

@janechu janechu Awaiting requested review from janechu janechu is a code owner

@radium-v radium-v Awaiting requested review from radium-v radium-v is a code owner

@khamudom khamudom Awaiting requested review from khamudom

Assignees

@freefaller69 freefaller69

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@freefaller69 @nicholasrice @eljefe223 @SamanthaAO