fix(fast-element): default event handler behavior should be no capture #3337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EisenbergEffect
requested review from
chrisdholt,
janechu and
nicholasrice
as code owners
|
Ping @nicholasrice |
|
Thanks @EisenbergEffect - looking now. |
|
@EisenbergEffect Didn't see any components misbehaving - gtg! |
nicholasrice
approved these changes
Jun 18, 2020
radium-v
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Super quick fix to change the default event listener behavior to not capture (this was an oopsie on my part). I'll circle back around and add more tests to binding in general when some time opens up.
Issue type checklist
Is this a breaking change?
This is technically a breaking change.
Process & policy checklist