Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update to absolute paths when converting README files #3325

Merged
merged 5 commits into from
Jun 19, 2020
Merged

chore: update to absolute paths when converting README files #3325

merged 5 commits into from
Jun 19, 2020

Conversation

janechu
Copy link
Collaborator

@janechu janechu commented Jun 16, 2020 •
edited
Loading

Description

This changes relative paths such as "../../../my-spec-file.md" to an absolute path to the github repository markdown.

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@janechu janechu requested a review from nicholasrice as a code owner June 16, 2020 22:27
@janechu janechu self-assigned this Jun 16, 2020
@EisenbergEffect EisenbergEffect mentioned this pull request Jun 16, 2020
Closed
35 tasks
@awentzel awentzel changed the title chore: replace relative paths with absolute paths when README files are converted chore: update to absolute paths when converting README files Jun 18, 2020
chrisdholt
chrisdholt approved these changes Jun 19, 2020
View reviewed changes
Copy link
Member

@chrisdholt chrisdholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one possible issue with a couple missing characters, but looks good aside from that.

sites/fast-component-explorer/build/convert-readme.js Show resolved Hide resolved
@janechu janechu merged commit ccc34f6 into master Jun 19, 2020
@janechu janechu deleted the users/janechu/replace-links-in-readme-with-true-pathing branch June 19, 2020 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdholt chrisdholt chrisdholt approved these changes

@awentzel awentzel awentzel approved these changes

@nicholasrice nicholasrice Awaiting requested review from nicholasrice

Assignees

@janechu janechu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janechu @chrisdholt @awentzel