feat(fast-element): enable children and slotted filters #3323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EisenbergEffect
requested review from
chrisdholt,
janechu and
nicholasrice
as code owners
janechu
approved these changes
Jun 16, 2020
packages/web-components/fast-element/src/directives/node-observation.ts
Outdated
Show resolved
Hide resolved
nicholasrice
approved these changes
Jun 16, 2020
EisenbergEffect
deleted the
users/eisenbergeffect/slot-children-filter-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a long requested feature to
slottedandchildrendirectives to be able to supply a filter for what nodes you want pushed into your property. For convenience, anelements()filter was added to enable easy filtering of only elements or elements with a particular tag name.As part of this work, unit tests were added for both
slottedandchildrenand a couple of bugs in both typings and functionality were discovered as a result.Issue type checklist
This is not a breaking change.
Process & policy checklist
The documentation update will come as part of my upcoming documentation PR, which is currently in draft form. I'll add it there in order to avoid some conflicts.