Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add the new logo and inline logo for FAST as the favicon and inline logo in Creator, Component Explorer and Tooling examples #3313

Merged

Conversation

janechu
Copy link
Collaborator

@janechu janechu commented Jun 15, 2020

Description

This PR:

  • Adds the logo as a favicon using a webpack plugin
  • Adds the inline logo using the file-loader
  • Consolidates the inline logo into its own component and places it in the site-utilities

Motivation & context

This provides consistency between the Creator and Component explorer for the logo section and updates the logos for all three sites, Creator, Component Explorer and Tooling examples.

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@janechu janechu self-assigned this Jun 15, 2020
@EisenbergEffect EisenbergEffect mentioned this pull request Jun 16, 2020
35 tasks
@awentzel
Copy link
Collaborator

@janechu given this is a CDN, we may want to namespace the logo file name and/or by directory to separate between Fast investments (different tools etc)

@janechu janechu force-pushed the users/janechu/update-logos-in-creator-and-component-explorer branch from ead0187 to 591e1c2 Compare June 17, 2020 20:34
janechu added 2 commits June 17, 2020 15:33
…nline logo in Creator, Component Explorer and Tooling examples
@janechu janechu force-pushed the users/janechu/update-logos-in-creator-and-component-explorer branch from 591e1c2 to caf3faa Compare June 17, 2020 22:35
@janechu janechu force-pushed the users/janechu/update-logos-in-creator-and-component-explorer branch from caf3faa to 8558171 Compare June 17, 2020 23:08
@janechu janechu merged commit 599b6ca into master Jun 17, 2020
@janechu janechu deleted the users/janechu/update-logos-in-creator-and-component-explorer branch June 17, 2020 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants