Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adds backdrop to tablist in fast-frame #3245

Merged
merged 2 commits into from
Jun 8, 2020
Merged

chore: adds backdrop to tablist in fast-frame #3245

merged 2 commits into from
Jun 8, 2020

Conversation

eljefe223
Copy link
Contributor

@eljefe223 eljefe223 commented Jun 8, 2020 •
edited
Loading

Description

Adds the backdrop to the tablist in fast-frame to match the designs. This currently leaves out the blue for performance reasons.

Screen Shot 2020-06-08 at 11 55 02 AM

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@eljefe223 eljefe223 self-assigned this Jun 8, 2020
freefaller69
freefaller69 approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@freefaller69 freefaller69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great in Edge, Firefox, Chrome, and Opera.

khamudom
khamudom approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@khamudom khamudom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-smoked. looks good.

@eljefe223 eljefe223 merged commit 4cd7970 into feature/fast-frame Jun 8, 2020
@eljefe223 eljefe223 deleted the users/jes/tablist-backdrop branch June 8, 2020 19:53
chrisdholt pushed a commit that referenced this pull request Jun 11, 2020
@eljefe223 @chrisdholt
chore: adds backdrop to tablist in fast-frame (#3245)
2ade879 
* feat: adds backdrop to tablist in fast-frame

* updated design based on feedback from Jason
chrisdholt pushed a commit that referenced this pull request Jun 16, 2020
@eljefe223 @chrisdholt
chore: adds backdrop to tablist in fast-frame (#3245)
4997ad0 
* feat: adds backdrop to tablist in fast-frame

* updated design based on feedback from Jason
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khamudom khamudom khamudom approved these changes

@freefaller69 freefaller69 freefaller69 approved these changes

@nicholasrice nicholasrice nicholasrice approved these changes

@radium-v radium-v Awaiting requested review from radium-v

@chrisdholt chrisdholt Awaiting requested review from chrisdholt

@SamanthaAO SamanthaAO Awaiting requested review from SamanthaAO

@janechu janechu Awaiting requested review from janechu

Assignees

@eljefe223 eljefe223

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eljefe223 @nicholasrice @freefaller69 @khamudom