chore: update card/content styling to match figma #3228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamanthaAO
requested review from
chrisdholt,
janechu and
nicholasrice
as code owners
nicholasrice
reviewed
Jun 4, 2020
...bsite/src/app/components/content-placement-container/content-placement-container.template.ts
Outdated
Show resolved
Hide resolved
radium-v
reviewed
Jun 4, 2020
...bsite/src/app/components/content-placement-container/content-placement-container.template.ts
Outdated
Show resolved
Hide resolved
...bsite/src/app/components/content-placement-container/content-placement-container.template.ts
Outdated
Show resolved
Hide resolved
chrisdholt
force-pushed
the
feature/fast-frame
branch
from
b28a5cf to
1d74f0a
Compare
SamanthaAO
requested review from
awentzel,
EisenbergEffect and
Falkicon
as code owners
SamanthaAO
force-pushed
the
users/v-sorcut/content-style-update
branch
from
3c2a2e5 to
685b4f4
Compare
SamanthaAO
force-pushed
the
users/v-sorcut/content-style-update
branch
from
685b4f4 to
bbddda4
Compare
freefaller69
reviewed
Jun 5, 2020
...website/src/app/components/content-placement-container/content-placement-container.styles.ts
Show resolved
Hide resolved
freefaller69
approved these changes
Jun 5, 2020
SamanthaAO
force-pushed
the
users/v-sorcut/content-style-update
branch
from
b739f15 to
b9772ec
Compare
eljefe223
approved these changes
Jun 8, 2020
…ture cards using index instead of data file, add header subscript to framework cards
…changes associated witht it. change span for headingSubscript to small
SamanthaAO
force-pushed
the
users/v-sorcut/content-style-update
branch
from
b9772ec to
f053965
Compare
nicholasrice
approved these changes
Jun 9, 2020
chrisdholt
pushed a commit
that referenced
this pull request
Jun 11, 2020
* grey out links on non hovered community cards, display numbers on feature cards using index instead of data file, add header subscript to framework cards * change numbering on feature cards from index to css and make styling changes associated witht it. change span for headingSubscript to small * remove positioning in feature since we no longer use index
chrisdholt
pushed a commit
that referenced
this pull request
Jun 16, 2020
* grey out links on non hovered community cards, display numbers on feature cards using index instead of data file, add header subscript to framework cards * change numbering on feature cards from index to css and make styling changes associated witht it. change span for headingSubscript to small * remove positioning in feature since we no longer use index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update: numbers on feature cards are now displayed using css
Community before:
Community after:
Frameworks before:
Frameworks after:
Motivation & context
Issue type checklist
Is this a breaking change?
Process & policy checklist