Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update to add intersection observer to resolve scroll issue #3222

Merged
merged 1 commit into from
Jun 4, 2020
Merged

fix: update to add intersection observer to resolve scroll issue #3222

merged 1 commit into from
Jun 4, 2020

Conversation

SamanthaAO
Copy link
Contributor

Description

  • update intersection observer to fix scroll issue
  • add typescript to clickHandler
  • remove special styling on hero section so when it is scrolled to the section below is not visible

Motivation & context

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@SamanthaAO SamanthaAO self-assigned this Jun 3, 2020
@SamanthaAO SamanthaAO force-pushed the users/v-sorcut/small-screen-scroll branch from e81dbb6 to 002e2e8 Compare June 3, 2020 20:02
@awentzel awentzel changed the title fix: fix scroll issue when screen is reduced in the y direction fix: update to add intersection observer to resolve scroll issue Jun 4, 2020
@awentzel awentzel merged commit 855b565 into feature/fast-frame Jun 4, 2020
@awentzel awentzel deleted the users/v-sorcut/small-screen-scroll branch June 4, 2020 15:53
chrisdholt pushed a commit that referenced this pull request Jun 4, 2020
@SamanthaAO @chrisdholt
fix small screen scroll issue, add typescript to click event handler,…
f0846ac 
… remove special styling for section-hero (#3222)
chrisdholt pushed a commit that referenced this pull request Jun 11, 2020
@SamanthaAO @chrisdholt
fix small screen scroll issue, add typescript to click event handler,…
00c67f1 
… remove special styling for section-hero (#3222)
chrisdholt pushed a commit that referenced this pull request Jun 16, 2020
@SamanthaAO @chrisdholt
fix small screen scroll issue, add typescript to click event handler,…
08b5f3a 
… remove special styling for section-hero (#3222)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janechu janechu janechu approved these changes

@nicholasrice nicholasrice nicholasrice approved these changes

@radium-v radium-v Awaiting requested review from radium-v

@freefaller69 freefaller69 Awaiting requested review from freefaller69

@eljefe223 eljefe223 Awaiting requested review from eljefe223

@khamudom khamudom Awaiting requested review from khamudom

@chrisdholt chrisdholt Awaiting requested review from chrisdholt

Assignees

@SamanthaAO SamanthaAO

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SamanthaAO @nicholasrice @janechu @awentzel